Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ignore error in cleanup function #649

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

Letty5411
Copy link
Contributor

@Letty5411 Letty5411 commented Jan 26, 2018

Signed-off-by: letty [email protected]

1.Describe what this PR did
When call cleanup function in SetupTest, we could ignore the error.
As this is not the test point, if you really wanna test cleanup work, you could code it explicitly in Test cases.
2.Does this pull request fix one issue?

3.Describe how you did it

4.Describe how to verify it

5.Special notes for reviews

@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/S labels Jan 26, 2018
@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 26, 2018
@allencloud allencloud merged commit 4f8c70b into AliyunContainerService:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants