bugfix: can remove the exited container without flag force. #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skoo87 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
=======================================
Coverage 14.21% 14.21%
=======================================
Files 65 65
Lines 3736 3736
=======================================
Hits 531 531
Misses 3159 3159
Partials 46 46
Continue to review full report at Codecov.
|
pouchrobot
added
the
LGTM
Letty5411
reviewed
Jan 25, 2018
| @@ -163,7 +163,7 @@ func (mgr *ContainerManager) Remove(ctx context.Context, name string, option *Co | |||
| c.Lock() | |||
| defer c.Unlock() | |||
|
|
|||
| if !c.IsStopped() && !c.IsCreated() && !option.Force { | |||
| if !c.IsStopped() && !c.IsExited() && !c.IsCreated() && !option.Force { | |||
| return fmt.Errorf("container: %s is not stopped, can't remove it without flag force", c.ID()) | |||
There was a problem hiding this comment.
Do we need to also change the error message?
There was a problem hiding this comment.
I think it's unnecessary ....
Letty5411
removed
the
LGTM
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: skoo87 [email protected]
1.Describe what this PR did
2.Does this pull request fix one issue?
fix #639
3.Describe how you did it
4.Describe how to verify it
5.Special notes for reviews