-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add volume list command #578
Conversation
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 13.58% 13.43% -0.15%
==========================================
Files 65 65
Lines 3541 3579 +38
==========================================
Hits 481 481
- Misses 3010 3048 +38
Partials 50 50
Continue to review full report at Codecov.
|
Could you add some integration test including API test case and cli test case? @rudyfly |
@allencloud @Letty5411 How to add integration test,can you give me an example? |
Yes, you can take a look at file The previous one is focused on API integration test and the latter one is cli integration test. @rudyfly |
Add volume list command, it returns all the volumes in pouch. Now it just returns the name of volume. Signed-off-by: Rudy Zhang <[email protected]>
@allencloud @Letty5411 PTAL. |
LGTM, while I would like to invite @Letty5411 to double check this. |
LGTM |
1.Describe what this PR did
Add volume list command, it returns all the volumes in pouch.
Now it just returns the name of volume.
2.Does this pull request fix one issue?
NONE
3.Describe how you did it
4.Describe how to verify it
create three volume in pouchd
then use list to get the volumes that are created just now.
5.Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]