refactor: mv EnableLxcfs from ContainerConfig to HostConfig #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: codejuan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 14.24% 14.24%
=======================================
Files 64 64
Lines 3159 3159
=======================================
Hits 450 450
Misses 2664 2664
Partials 45 45
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Describe what this PR did
According to the definition of ContainerConfig and HostConfig, the field lxcfs is rely to host, so it's better to mv it from ContainerConfig to HostConfig.