Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: use created instead of startedAt in /container/:name/json #547

Merged
merged 1 commit into from
Jan 10, 2018
Merged

bugfix: use created instead of startedAt in /container/:name/json #547

merged 1 commit into from
Jan 10, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Jan 10, 2018

Signed-off-by: Wei Fu [email protected]

1.Describe what this PR did

The pouch inspect should show created time, not started at

2.Does this pull request fix one issue?

#544

3.Describe how you did it

NONE

4.Describe how to verify it

➜  pouch git:(bugfix_should_use_created_instead_of_started) pouch run --name test registry.hub.docker.com/library/busybox:latest sleep 3
➜  pouch git:(bugfix_should_use_created_instead_of_started) pouch inspect test
{
  "Args": null,
  "Config": {
    "Cmd": [
      "sleep",
      "3"
    ],
    "Entrypoint": null,
    "Env": [
      "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
    ],
    "Image": "registry.hub.docker.com/library/busybox:latest",
    "OnBuild": null,
    "Shell": null
  },
  "Created": "2018-01-10 13:53:51",
  "HostConfig": {
    "Runtime": "runc",
    "BlkioDeviceReadBps": null,
    "BlkioDeviceReadIOps": null,
    "BlkioDeviceWriteBps": null,
    "BlkioDeviceWriteIOps": null,
    "BlkioWeightDevice": null,
    "DeviceCgroupRules": null,
    "Devices": [],
    "MemorySwappiness": -1,
    "Ulimits": null
  },
  "Id": "a695c3f75854af38a9cf6ef5676cee0244a5c59a0dc841ac27a5ee5812abf32f",
  "Image": "registry.hub.docker.com/library/busybox:latest",
  "Mounts": null,
  "Name": "test",
  "State": {
    "FinishedAt": "2018-01-10 13:53:55",
    "Pid": -1,
    "StartedAt": "2018-01-10 13:53:52",
    "Status": "stopped"
  }
}

5.Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Jan 10, 2018
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #547 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #547   +/-   ##
=======================================
  Coverage   20.47%   20.47%           
=======================================
  Files          39       39           
  Lines        2056     2056           
=======================================
  Hits          421      421           
  Misses       1590     1590           
  Partials       45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64393b...8575b31. Read the comment docs.

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 10, 2018
@allencloud allencloud merged commit c886ee7 into AliyunContainerService:master Jan 10, 2018
@fuweid fuweid deleted the bugfix_should_use_created_instead_of_started branch January 10, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants