refactor: encapsulate codes into function FormatStatus #542
Conversation
|
|
|
Thanks a lot for your work. 🌹 |
daemon/mgr/container_types.go
Outdated
| var status string | ||
|
|
||
| if meta.State.Status == types.StatusRunning || meta.State.Status == types.StatusPaused { | ||
| start, _ := time.Parse(utils.TimeLayout, meta.State.StartedAt) |
There was a problem hiding this comment.
Please do not ignore this error.
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
+ Coverage 14.24% 14.49% +0.25%
==========================================
Files 64 64
Lines 3159 3173 +14
==========================================
+ Hits 450 460 +10
- Misses 2664 2666 +2
- Partials 45 47 +2
Continue to review full report at Codecov.
|
|
Should I add unit test in utils_test.go or somewhere? @allencloud |
|
In |
Signed-off-by: zeppp <[email protected]>
zeppp
force-pushed
the
refactor-FormatStatus
branch
from
50b9718 to
4498efa
Compare
apis/server/container_bridge.go
Outdated
| } | ||
| } else { | ||
| container.Status = string(m.State.Status) | ||
| status, err := m.FormatStatus() |
There was a problem hiding this comment.
Move this part above above container := types.Container{ and still in the for loop, then we can add status when constructing the instance, like:
container := types.Container{
ID: m.ID,
Names: []string{m.Name},
Image: m.Config.Image,
Command: strings.Join(m.Config.Cmd, " "),
Created: t.UnixNano(),
Labels: m.Config.Labels,
HostConfig: m.HostConfig,
Status: status,
}
Signed-off-by: zeppp <[email protected]>
zeppp
force-pushed
the
refactor-FormatStatus
branch
from
4498efa to
e32c190
Compare
|
LGTM, much better now. |
pouchrobot
added
the
LGTM
Signed-off-by: zeppp [email protected]
1.Describe what this PR did
encapsulate codes into function FormatStatus
2.Does this pull request fix one issue?
3.Describe how you did it
4.Describe how to verify it
5.Special notes for reviews