-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add more info in test.md #533
Conversation
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
======================================
Coverage 17.2% 17.2%
======================================
Files 38 38
Lines 2040 2040
======================================
Hits 351 351
Misses 1653 1653
Partials 36 36 Continue to review full report at Codecov.
|
docs/test/test.md
Outdated
* [unit testing](https://en.wikipedia.org/wiki/Unit_testing#Description) | ||
* [integration testing](https://en.wikipedia.org/wiki/Integration_testing) | ||
|
||
More info could be get from the wiki page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/get/gotten ?
docs/test/test.md
Outdated
|
||
More info could be get from the wiki page. | ||
|
||
For pouch developer, if your code is only used in a single module, then the unit test is enough. While if your code is called by multiple modules, integration tests are required. In pouch, both of them are developed using go language. More details could be got in [Unit Testing](#unit-testing) and [Integration Testing](#integration-testing). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/got/gotten ?
Please note that, in order to run test, the following prerequisites are needed: | ||
|
||
* golang is installed | ||
* docker is installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, we will replace docker with pouch itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, when pouch support build option~
Signed-off-by: letty <[email protected]>
LGTM |
Signed-off-by: letty [email protected]
1.Describe what this PR did
Add more info in test.md.
2.Does this pull request fix one issue?
3.Describe how you did it
4.Describe how to verify it
5.Special notes for reviews