fix: make cpuquota, MemorySwappiness validation compatible with docker #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
==========================================
- Coverage 69% 68.96% -0.04%
==========================================
Files 277 277
Lines 18298 18298
==========================================
- Hits 12626 12619 -7
- Misses 4246 4253 +7
Partials 1426 1426
|
zhuangqh
force-pushed
the
fix-validation-rule
branch
from
029d517 to
6bc8a39
Compare
allencloud
reviewed
Nov 19, 2018
apis/swagger.yml
Outdated
| @@ -2663,7 +2662,7 @@ definitions: | |||
| description: "Tune a container's memory swappiness behavior. Accepts an integer between 0 and 100." | |||
There was a problem hiding this comment.
Please add more details in the description?
HusterWan
reviewed
Nov 19, 2018
| @@ -115,7 +115,7 @@ func (suite *PouchRunMemorySuite) TestRunWithMemoryswappiness(c *check.C) { | |||
| "--memory-swappiness", "-1", | |||
| "--name", cname, busyboxImage, "top") | |||
| DelContainerForceMultyTime(c, cname) | |||
| c.Assert(res.ExitCode, check.Equals, 1) | |||
There was a problem hiding this comment.
If we use the swagger validation, this test case should not passed, Right?
refactor: logCreateOption before validation, it enable developer to see what's wrong. Signed-off-by: zhuangqh <[email protected]>
zhuangqh
force-pushed
the
fix-validation-rule
branch
from
6bc8a39 to
335c90c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhuangqh [email protected]
Ⅰ. Describe what this PR did
correct validation rule
refactor: logCreateOption before validation, it enable developer to see what's wrong.
Ⅱ. Does this pull request fix one issue?
fixes #2473
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
stricter validation in github.com/alibaba/pouch/daemon/mgr/container_validation.go