Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix dead link in dragonfly #2468

Merged
merged 1 commit into from
Nov 21, 2018
Merged

docs: fix dead link in dragonfly #2468

merged 1 commit into from
Nov 21, 2018

Conversation

Ace-Tang
Copy link
Contributor

@Ace-Tang Ace-Tang commented Nov 13, 2018

change links in dragonfly docs, since dragonfly do a refactor.

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fix dragonfly part in #2466

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

❗ No coverage uploaded for pull request head (fix_dead_link@2696374). Click here to learn what that means.
The diff coverage is n/a.

@Ace-Tang
Copy link
Contributor Author

/cc @allencloud


2.install client

- Downloading [client package](https://github.com/alibaba/Dragonfly/blob/master/package/df-client.linux-amd64.tar.gz).
- Downloading client from [dragonfly release](https://github.com/alibaba/Dragonfly/releases).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dragonflyoss/Dragonfly could you update the link? thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the different between https://github.com/alibaba/Dragonfly and https://github.com/dragonflyoss/Dragonfly, I get confused now .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dragonfly has been donated to the CNCF, and it has been moved to another organization which is named by dragonflyoss, see https://github.com/dragonflyoss/dragonfly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, seems I need to refactor again

@allencloud
Copy link
Collaborator

@Ace-Tang Please change the organization name to dragonflyoss. Thanks.

change links in dragonfly docs, since dragonfly do a refactor.

Signed-off-by: Ace-Tang <[email protected]>
@Ace-Tang
Copy link
Contributor Author

Update, @allencloud

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Nov 21, 2018
@allencloud allencloud merged commit 4d421ec into AliyunContainerService:master Nov 21, 2018
@Ace-Tang Ace-Tang deleted the fix_dead_link branch November 21, 2018 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants