Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor api_pause_test use util func #2433

Merged

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Nov 6, 2018

Signed-off-by: zhangyue [email protected]

Ⅰ. Describe what this PR did

As the title desc, use PauseContainerOk/unPauseContainerOk func to refactor the test code.

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

None.

Ⅳ. Describe how to verify it

wait for CI pass.

Ⅴ. Special notes for reviews

None.

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #2433 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2433      +/-   ##
==========================================
- Coverage   68.73%   68.62%   -0.12%     
==========================================
  Files         272      272              
  Lines       18159    18159              
==========================================
- Hits        12482    12462      -20     
- Misses       4258     4272      +14     
- Partials     1419     1425       +6
Flag Coverage Δ
#criv1alpha1test 31.48% <ø> (+0.08%) ⬆️
#criv1alpha2test 35.66% <ø> (-0.09%) ⬇️
#integrationtest 40.11% <ø> (+0.08%) ⬆️
#nodee2etest 32.78% <ø> (-0.1%) ⬇️
#unittest 26.52% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/ocicni/cni_manager.go 59.18% <0%> (-12.25%) ⬇️
pkg/streams/utils.go 82.14% <0%> (-9.53%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
cri/v1alpha2/cri.go 67.56% <0%> (-0.74%) ⬇️
ctrd/container.go 58.49% <0%> (-0.4%) ⬇️
cri/v1alpha2/cri_utils.go 90.92% <0%> (-0.3%) ⬇️
daemon/mgr/container.go 58.79% <0%> (-0.22%) ⬇️
ctrd/image.go 78.94% <0%> (+2.19%) ⬆️
daemon/mgr/snapshot.go 94.2% <0%> (+4.34%) ⬆️

@HusterWan
Copy link
Contributor

LGTM, after the ci pass, I will merge this pr.

thanks a lot for your work. @ZYecho

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Nov 6, 2018
@allencloud allencloud merged commit 3d97439 into AliyunContainerService:master Nov 6, 2018
@ZYecho ZYecho deleted the refactor-test-pause branch November 6, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/refactor LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants