docs: user general pouchlinter to linter pouch's code #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2421 +/- ##
==========================================
+ Coverage 64.07% 68.61% +4.53%
==========================================
Files 275 275
Lines 18309 18309
==========================================
+ Hits 11731 12562 +831
+ Misses 5292 4327 -965
- Partials 1286 1420 +134
|
allencloud
force-pushed
the
use-pouchlinter
branch
2 times, most recently
from
f98b70d to
ddb1434
Compare
Signed-off-by: Allen Sun <[email protected]>
allencloud
force-pushed
the
use-pouchlinter
branch
from
ddb1434 to
04037f7
Compare
|
The gometalinter works. @fuweid |
|
Some scripts are used to help developer to install dependences easier. I think we can keep it. |
fuweid
reviewed
Nov 5, 2018
| command: make check | ||
| name: validate go code with gometalinter | ||
| command: | | ||
| gometalinter --disable-all --skip vendor -E gofmt -E goimports -E golint -E ineffassign -E misspell -E vet -E megacheck ./... |
There was a problem hiding this comment.
one more question, could we just use make check here, since the image provides the binary?
There was a problem hiding this comment.
I think both are OK, while if we use make check, the calling path is a little bit long. For the test part and ci part, in my opinion, simplicity is the most important thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
user general pouchlinter to linter pouch's code.
For more info about pouchlinter, please check https://github.com/pouchcontainer/pouchlinter
The doc change in test.md and pouch_with_plugin.md is according to markdowinlint rule https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md#md046---code-block-style .
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none