Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support get security options in daemon #2408

Merged
merged 1 commit into from
Nov 2, 2018
Merged

feature: support get security options in daemon #2408

merged 1 commit into from
Nov 2, 2018

Conversation

Ace-Tang
Copy link
Contributor

@Ace-Tang Ace-Tang commented Nov 1, 2018

show daemon security options, include four part,
seccomp, apparmor, selinux and userns.

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

support security information showed by pouch info , show daemon security options, include four part,
seccomp, apparmor, selinux and userns.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #2408 into master will increase coverage by 0.06%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2408      +/-   ##
==========================================
+ Coverage   68.39%   68.46%   +0.06%     
==========================================
  Files         275      275              
  Lines       18278    18291      +13     
==========================================
+ Hits        12502    12523      +21     
+ Misses       4348     4341       -7     
+ Partials     1428     1427       -1
Flag Coverage Δ
#criv1alpha1test 31.66% <0%> (-0.04%) ⬇️
#criv1alpha2test 35.88% <0%> (+0.23%) ⬆️
#integrationtest 39.77% <50%> (ø) ⬆️
#nodee2etest 33.28% <0%> (+0.08%) ⬆️
#unittest 25.52% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
daemon/mgr/spec_seccomp_linux.go 71.42% <0%> (-7.52%) ⬇️
daemon/mgr/spec_seccomp_unsupported.go 66.66% <100%> (+16.66%) ⬆️
daemon/mgr/system.go 73.28% <40%> (+2.79%) ⬆️
pkg/meta/store.go 66.15% <0%> (-1.54%) ⬇️
daemon/mgr/container_utils.go 85.44% <0%> (-1.27%) ⬇️
ctrd/container.go 59.28% <0%> (-0.48%) ⬇️
cri/v1alpha2/cri_wrapper.go 62.4% <0%> (ø) ⬆️
daemon/mgr/container.go 59.8% <0%> (+0.21%) ⬆️
cri/v1alpha2/cri_utils.go 90.8% <0%> (+0.28%) ⬆️
cri/v1alpha2/cri.go 68.53% <0%> (+0.59%) ⬆️
... and 2 more

show daemon security options, include four part,
seccomp, apparmor, selinux and userns.

Signed-off-by: Ace-Tang <[email protected]>
@fuweid
Copy link
Contributor

fuweid commented Nov 1, 2018

link #2116

@Ace-Tang
Copy link
Contributor Author

Ace-Tang commented Nov 2, 2018

Thanks for @fuweid , but the pr not link to the issue, I will created the PR to fix the issue soon.

@fuweid
Copy link
Contributor

fuweid commented Nov 2, 2018

basically, LGTM. But we need to add blank line between different package group.

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants