Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update "github.com/contiv/executor" #2407

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Nov 1, 2018

Ⅰ. Describe what this PR did

update "github.com/contiv/executor" in vendor.
Update "github.com/Sirupsen/logrus" to "github.com/sirupsen/logrus"

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

NONE

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang [email protected]

@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #2407 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2407      +/-   ##
==========================================
- Coverage   68.57%   68.49%   -0.09%     
==========================================
  Files         275      275              
  Lines       18278    18278              
==========================================
- Hits        12535    12520      -15     
- Misses       4327     4334       +7     
- Partials     1416     1424       +8
Flag Coverage Δ
#criv1alpha1test 31.94% <ø> (+0.06%) ⬆️
#criv1alpha2test 35.72% <ø> (+0.06%) ⬆️
#integrationtest 39.78% <ø> (-0.06%) ⬇️
#nodee2etest 33.24% <ø> (-0.07%) ⬇️
#unittest 25.53% <ø> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/snapshot.go 89.85% <0%> (-4.35%) ⬇️
daemon/containerio/cri_log_file.go 84.31% <0%> (-3.93%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
cri/v1alpha2/cri_wrapper.go 62.4% <0%> (-1.21%) ⬇️
ctrd/container.go 58.8% <0%> (-0.48%) ⬇️
cri/v1alpha2/cri.go 67.93% <0%> (-0.36%) ⬇️
daemon/mgr/container.go 59.8% <0%> (ø) ⬆️

@rudyfly rudyfly requested review from furykerry and fuweid and removed request for furykerry November 1, 2018 12:00
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But wait for CI

@allencloud
Copy link
Collaborator

I think the CRI-tools CI failure is not by coincidence. Please take a look of this. @starnop

@starnop
Copy link
Contributor

starnop commented Nov 1, 2018

@allencloud Something is wrong with #2271. @Ace-Tang Could you please help handle it? Thanks! :)

@Ace-Tang
Copy link
Contributor

Ace-Tang commented Nov 2, 2018

Please rebase the code.

update "github.com/contiv/executor" in vendor.

Signed-off-by: Rudy Zhang <[email protected]>
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants