-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update "github.com/contiv/executor" #2407
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2407 +/- ##
==========================================
- Coverage 68.57% 68.49% -0.09%
==========================================
Files 275 275
Lines 18278 18278
==========================================
- Hits 12535 12520 -15
- Misses 4327 4334 +7
- Partials 1416 1424 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But wait for CI
I think the CRI-tools CI failure is not by coincidence. Please take a look of this. @starnop |
@allencloud Something is wrong with #2271. @Ace-Tang Could you please help handle it? Thanks! :) |
Please rebase the code. |
update "github.com/contiv/executor" in vendor. Signed-off-by: Rudy Zhang <[email protected]>
180762d
to
a39c1c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
update "github.com/contiv/executor" in vendor.
Update
"github.com/Sirupsen/logrus"
to"github.com/sirupsen/logrus"
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
NONE
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]