Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CriEnabled field in the doc of deploy kubernetes with PouchContainer #2382

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

hellolijj
Copy link
Contributor

Ⅰ. Describe what this PR did

update CriEnabled field in the doc of deploy kubernetes with PouchContainer

Ⅱ. Does this pull request fix one issue?

fixes #2381

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

❗ No coverage uploaded for pull request head (issue2381@2a1f05a). Click here to learn what that means.
The diff coverage is n/a.

@pouchrobot
Copy link
Collaborator

@hellolijj Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @hellolijj
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2018

CLA assistant check
All committers have signed the CLA.

@fuweid
Copy link
Contributor

fuweid commented Oct 30, 2018

@hellolijj could you please to sign the CLA? thanks

@allencloud
Copy link
Collaborator

In the cli code of info command, there is code:

	fmt.Fprintln(os.Stdout, "LxcfsEnabled: ", info.LxcfsEnabled)
	fmt.Fprintln(os.Stdout, "CriEnabled: ", info.CriEnabled)
	if info.RegistryConfig != nil && (len(info.RegistryConfig.InsecureRegistryCIDRs) > 0 || len(info.RegistryConfig.IndexConfigs) > 0) {
		fmt.Fprintln(os.Stdout, "Insecure Registries: ")

In which there is CriEnabled rather than IsCRIEnabled . So LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 30, 2018
@allencloud
Copy link
Collaborator

It is the documentation update. And the doc CI passes. So merging.
Thanks @hellolijj for your contribution. And congratulations to be a PouchContainer contributor.

@allencloud allencloud merged commit 737a60c into AliyunContainerService:master Oct 30, 2018
@hellolijj hellolijj deleted the issue2381 branch October 30, 2018 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs areas/orchestration LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc incomplete: CriEnabled field in the document is differen from that in the pouch info
5 participants