Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add no-trunc flag for pouch images #2374

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Oct 28, 2018

Signed-off-by: zhangyue [email protected]

Ⅰ. Describe what this PR did

As the title desc, add a --no-trunc flag for pouch images cmd to show to whole image Id, also and cli samples to end-users.

Ⅱ. Does this pull request fix one issue?

fixes #2371

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

add test.

Ⅳ. Describe how to verify it

go test -gocheck.f PouchImagesSuite

Ⅴ. Special notes for reviews

None.

@codecov
Copy link

codecov bot commented Oct 28, 2018

Codecov Report

Merging #2374 into master will decrease coverage by 2.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2374      +/-   ##
==========================================
- Coverage   66.82%   64.48%   -2.34%     
==========================================
  Files         265      265              
  Lines       18211    18211              
==========================================
- Hits        12169    11743     -426     
- Misses       4637     5176     +539     
+ Partials     1405     1292     -113
Flag Coverage Δ
#criv1alpha1test 43.82% <ø> (+12.34%) ⬆️
#criv1alpha2test 35.58% <ø> (-64.42%) ⬇️
#integrationtest 39.43% <ø> (-0.13%) ⬇️
#nodee2etest 32.99% <ø> (+0.01%) ⬆️
#unittest 25.52% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha1/cri_types.go 0% <0%> (-100%) ⬇️
cri/v1alpha1/service/cri.go 0% <0%> (-84.62%) ⬇️
cri/v1alpha1/server.go 0% <0%> (-79.2%) ⬇️
cri/v1alpha1/cri.go 0% <0%> (-60.39%) ⬇️
cri/v1alpha1/cri_wrapper.go 0% <0%> (-55.31%) ⬇️
cri/v1alpha1/cri_stream.go 28.57% <0%> (-37.15%) ⬇️
cri/criservice.go 34.52% <0%> (-21.43%) ⬇️
cri/ocicni/cni_manager.go 59.18% <0%> (-12.25%) ⬇️
daemon/mgr/system.go 70.49% <0%> (-5.74%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
... and 16 more

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 2170591 into AliyunContainerService:master Oct 30, 2018
@ZYecho ZYecho deleted the add-images-noTrunc branch November 6, 2018 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Is there a need to support pouch images filter and no-trunc flag?
3 participants