fix dead code and clean code format #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default section is never hit due to Strings.Count limitation and strings.SplitN slice, in other words, the part is dead code, this patch will fix it. apis.opts.mountpoint: fix dead code apis.opts.mountpoint_test: clean code format Signed-off-by: Alex Jia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
+ Coverage 66.66% 68.08% +1.41%
==========================================
Files 265 265
Lines 18209 18207 -2
==========================================
+ Hits 12139 12396 +257
+ Misses 4669 4392 -277
- Partials 1401 1419 +18
|
HusterWan
reviewed
Oct 25, 2018
| {bind: "volume-test::rw", len: 3, err: true, expectErr: fmt.Errorf("unknown volume bind: volume-test::rw")}, | ||
| {bind: "volume-test", len: 1, err: true, expectErr: fmt.Errorf("invalid bind path: volume-test")}, | ||
| {bind: ":mnt:rw", len: 3, err: true, expectErr: fmt.Errorf("invalid bind path: mnt")}, | ||
| { |
There was a problem hiding this comment.
why should we change one line to this structure? just caurious @chuanchang
There was a problem hiding this comment.
Actually I think the new way is much more readable. 😄
HusterWan
reviewed
Oct 25, 2018
| @@ -10,11 +10,7 @@ import ( | |||
|
|
|||
| // CheckBind is used to check the volume bind information. | |||
| func CheckBind(b string) ([]string, error) { | |||
| if strings.Count(b, ":") > 2 { | |||
There was a problem hiding this comment.
Why delete the : numbers check ?
There was a problem hiding this comment.
This is same as using the following code arr := strings.SplitN(b, ":", 3). @HusterWan
|
LGTM, while I would like to invite @rudyfly to take another review. |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default section is never hit due to Strings.Count
limitation and strings.SplitN slice, in other words,
the part is dead code, this patch will fix it.
apis.opts.mountpoint: fix dead code
apis.opts.mountpoint_test: clean code format
Signed-off-by: Alex Jia [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews