refactor: refact daemon log #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2324 +/- ##
==========================================
- Coverage 67.34% 67.33% -0.01%
==========================================
Files 218 218
Lines 17674 17675 +1
==========================================
- Hits 11902 11901 -1
- Misses 4365 4366 +1
- Partials 1407 1408 +1
|
HusterWan
reviewed
Oct 18, 2018
| @@ -855,7 +855,7 @@ func (c *CriManager) ListContainerStats(ctx context.Context, r *runtime.ListCont | |||
| for _, container := range containers { | |||
| cs, err := c.getContainerMetrics(ctx, container) | |||
| if err != nil { | |||
| logrus.Errorf("failed to decode metrics of container %q: %v", container.ID, err) | |||
There was a problem hiding this comment.
decode metrics log level keep as Error
Change the log level of all the "Get" method from "Info" to "Debug". Add the log to show set the disk quota information. Signed-off-by: Rudy Zhang <[email protected]>
|
LGTM. expect the comments above. Just a little tip: |
allencloud
reviewed
Oct 23, 2018
| @@ -94,12 +94,12 @@ func (c *CriWrapper) RemovePodSandbox(ctx context.Context, r *runtime.RemovePodS | |||
|
|
|||
| // PodSandboxStatus returns the status of the PodSandbox. | |||
| func (c *CriWrapper) PodSandboxStatus(ctx context.Context, r *runtime.PodSandboxStatusRequest) (res *runtime.PodSandboxStatusResponse, err error) { | |||
There was a problem hiding this comment.
So strange to see using a defer to cover a simple error asserting. 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Change the log level of all the "Get" method from "Info" to "Debug".
Add the log to show set the disk quota information.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
NONE
Ⅳ. Describe how to verify it
NONE
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]