Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add cri metrics #2304

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Oct 11, 2018

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

add metrics about grpc server of CRI Manager.

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #2304 into master will increase coverage by 0.26%.
The diff coverage is 87.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2304      +/-   ##
==========================================
+ Coverage   66.97%   67.23%   +0.26%     
==========================================
  Files         211      213       +2     
  Lines       17306    17465     +159     
==========================================
+ Hits        11591    11743     +152     
- Misses       4312     4327      +15     
+ Partials     1403     1395       -8
Flag Coverage Δ
#criv1alpha1test 32.15% <28.64%> (+0.07%) ⬆️
#criv1alpha2test 36.13% <81.4%> (+0.53%) ⬆️
#integrationtest 39.91% <30.15%> (-0.27%) ⬇️
#nodee2etest 33.67% <84.42%> (+0.55%) ⬆️
#unittest 23.21% <0.74%> (-0.2%) ⬇️
Impacted Files Coverage Δ
apis/metrics/metrics.go 100% <ø> (ø) ⬆️
apis/server/image_bridge.go 72.72% <100%> (ø) ⬆️
cri/v1alpha2/service/cri.go 89.47% <100%> (+3.75%) ⬆️
pkg/utils/metrics/metrics.go 100% <100%> (ø)
cri/metrics/metrics.go 100% <100%> (ø)
cri/v1alpha2/cri.go 68.85% <81.95%> (+2.52%) ⬆️
daemon/mgr/snapshot.go 89.85% <0%> (-4.35%) ⬇️
cri/v1alpha2/cri_wrapper.go 61.2% <0%> (-1.2%) ⬇️
... and 8 more

@starnop starnop changed the title [WIP] feature: add cri metrics feature: add cri metrics Oct 11, 2018
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allencloud allencloud merged commit 32febd1 into AliyunContainerService:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants