Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: fix typo on hack/install/install_ci_related.sh #2241

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

houstar
Copy link
Contributor

@houstar houstar commented Sep 14, 2018

Signed-off-by: Leno Hou [email protected]

Ⅰ. Describe what this PR did

typo issue on hack/install/install_ci_related.sh

Ⅱ. Does this pull request fix one issue?

No

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

No

Ⅳ. Describe how to verify it

No

Ⅴ. Special notes for reviews

No

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Sep 14, 2018
@allencloud allencloud merged commit c7d73e1 into AliyunContainerService:master Sep 14, 2018
@fuweid
Copy link
Contributor

fuweid commented Sep 17, 2018

ping @houstar thanks for fixing typo. since we have the typo detecter in CI, it seems that it doesn't work well. could you help us to check the CI? thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test areas/typo LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants