feature: add CRI interface of start podsandbox #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
starnop
force-pushed
the
cri-StartPodSandbox
branch
3 times, most recently
from
ab4cd0b to
d0a559b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2237 +/- ##
==========================================
- Coverage 66.56% 66.41% -0.15%
==========================================
Files 208 208
Lines 16756 16782 +26
==========================================
- Hits 11153 11146 -7
- Misses 4276 4310 +34
+ Partials 1327 1326 -1
|
fuweid
reviewed
Sep 13, 2018
| string pod_sandbox_id = 1; | ||
| } | ||
|
|
||
| message StartPodSandboxResponse {} |
rudyfly
reviewed
Sep 13, 2018
cri/v1alpha2/cri.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| netnsPath, err := c.getNetnsPath(ctx, id, config.GetLinux().GetSecurityContext().GetNamespaceOptions().GetNetwork(), config) |
There was a problem hiding this comment.
modify the function's name, it will misunderstanding
starnop
force-pushed
the
cri-StartPodSandbox
branch
3 times, most recently
from
40d9b29 to
4331f4a
Compare
starnop
changed the title
starnop
force-pushed
the
cri-StartPodSandbox
branch
from
4331f4a to
c9101ea
Compare
starnop
changed the title
starnop
force-pushed
the
cri-StartPodSandbox
branch
from
c9101ea to
c9e31fb
Compare
YaoZengzeng
reviewed
Sep 14, 2018
cri/v1alpha2/cri_wrapper.go
Outdated
| @@ -56,6 +56,20 @@ func (c *CriWrapper) RunPodSandbox(ctx context.Context, r *runtime.RunPodSandbox | |||
| return c.CriManager.RunPodSandbox(ctx, r) | |||
| } | |||
|
|
|||
| // StartPodSandbox start a sandbox pod which was forced to stop by external factors. | |||
| // Network plugin returns same IPs when input same pod names and namespaces | |||
There was a problem hiding this comment.
Hmm... the comment seems wired to me 😂
Maybe the comment like this is more natural:
StartPodSandbox restart a sandbox pod which was stopped by accident and we should reconfigure it with network plugin which will make sure it reacquire its original network configuration, like IP address.
If it make any sense, please update other docs as well :)
There was a problem hiding this comment.
Has been updated. ^_^
Signed-off-by: Starnop <[email protected]>
starnop
force-pushed
the
cri-StartPodSandbox
branch
from
c9e31fb to
962b3f2
Compare
|
LGTM as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
Support to the ability to get the same IP after restart the PodSandbox.
Scenario: It will fail to get IP after PodSandbox restarts because of the external factors such as shutdown the host.
Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
The work of tests rely on the tools of
CRI-tools, in the meantime,CRI-toolsimports the project ofalibaba/pouch. So add the interface related, and hope to be merged ASAP, I will finish the details in the nextPull Request.