test: add node e2e test in CI #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starnop
force-pushed
the
cri-e2e-ci
branch
22 times, most recently
from
06d776f to
788b19a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
=========================================
+ Coverage 64.9% 67.01% +2.1%
=========================================
Files 208 208
Lines 16722 17064 +342
=========================================
+ Hits 10853 11435 +582
+ Misses 4519 4281 -238
+ Partials 1350 1348 -2
|
starnop
changed the title
|
This is really good. Thanks a lot for your work. @starnop |
|
👍 |
fuweid
reviewed
Sep 7, 2018
hack/install/install_critest.sh
Outdated
| fi | ||
|
|
||
| command -v ginkgo > /dev/null | ||
| chmod +x hack/install/install_ginkgo.sh |
There was a problem hiding this comment.
we can chmod hack/install/install_ginkgo.sh before push
| EOF' | ||
|
|
||
| echo | ||
| chmod +x hack/install/install_cni.sh |
There was a problem hiding this comment.
we can chmod file before push
starnop
force-pushed
the
cri-e2e-ci
branch
2 times, most recently
from
6855606 to
92a1a5b
Compare
fuweid
reviewed
Sep 7, 2018
Makefile
Outdated
| cri-e2e-test: ## run cri-e2e-test | ||
| @echo $@ | ||
| @mkdir -p coverage | ||
| @chmod +x ./hack/testing/run_daemon_cri_e2e.sh |
starnop
force-pushed
the
cri-e2e-ci
branch
7 times, most recently
from
5d2ec79 to
6d0a86d
Compare
Signed-off-by: Starnop <[email protected]>
|
Thanks for your review, I think maybe we could kick ball first, and see what will go on in the next CI. @fuweid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
Currently, we have added the unit tests related to CRI and the tests of CRI-tools to CI, but this is not reassuring enough, so we add the node e2e test to further guarantees the correctness of the project.
Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews