Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: update changelog and CONTRIBUTORS #2146

Merged
merged 1 commit into from
Aug 23, 2018
Merged

release: update changelog and CONTRIBUTORS #2146

merged 1 commit into from
Aug 23, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Aug 23, 2018

Signed-off-by: Wei Fu [email protected]

Ⅰ. Describe what this PR did

Update changelog for 1.0.0-rc2

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

😈

Ⅳ. Describe how to verify it

use CI to check the typo

Ⅴ. Special notes for reviews

CHANGELOG.md Outdated

### __Pouch Daemon__

* bugfix: fix runtime script may be coverd [\#2141](https://github.com/alibaba/pouch/pull/2141) ([Ace-Tang](https://github.com/Ace-Tang))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%s/coverd/covered

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

@HusterWan
Copy link
Contributor

lgtm

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 23, 2018
@HusterWan HusterWan merged commit b9724f2 into AliyunContainerService:master Aug 23, 2018
@fuweid fuweid deleted the release_update_changelog branch August 23, 2018 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/log LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants