bugfix: cannot get restartCount and let restartCount++ after restart container

[knightXun]

Ⅰ. Describe what this PR did

pouch inspect -f {{.RestartCount}} can't get corrent restartCount.Add one line code to fix it.
the restartCount will not change after manually restart a container, this pr fix it

Ⅱ. Does this pull request fix one issue?

1. when pouch inspect a container, we will get the restartCount of this container.
2. after restart a container, the restartCount++.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

[pouchrobot]

We found this is your first time to contribute to Pouch, @knightXun
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

[CLAassistant]

All committers have signed the CLA.

[knightXun]

/retest

[allencloud]

Actually we have not supported /retest comment to re-trigger test re-running. Add a issue pouchcontainer/pouchrobot#53 in pouchrobot.

[HusterWan]

@knightXun CRI test case failed has been solved, please rebase your pr , thanks a lot.

[knightXun]

@HusterWan thanks

[codecov-io]

Codecov Report

Merging #2132 into master will increase coverage by 0.06%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master    #2132      +/-   ##
==========================================
+ Coverage   64.38%   64.44%   +0.06%     
==========================================
  Files         209      209              
  Lines       16631    16638       +7     
==========================================
+ Hits        10708    10723      +15     
+ Misses       4595     4587       -8     
  Partials     1328     1328

Flag	Coverage Δ
#criv1alpha1test	32.97% <0%> (+0.01%)	⬆️
#criv1alpha2test	33.59% <0%> (+0.02%)	⬆️
#integrationtest	39.31% <87.5%> (+0.06%)	⬆️
#unittest	23.89% <0%> (-0.02%)	⬇️

Impacted Files	Coverage Δ
apis/server/container_bridge.go	75.92% <100%> (+0.08%)	⬆️
daemon/mgr/container.go	56.71% <71.42%> (+0.26%)	⬆️
ctrd/watch.go	72.72% <0%> (-7.58%)	⬇️
cri/stream/httpstream/spdy/upgrade.go	54.28% <0%> (-5.72%)	⬇️
cri/v1alpha2/cri.go	65.09% <0%> (+0.33%)	⬆️
cri/v1alpha1/cri.go	64.04% <0%> (+0.34%)	⬆️
ctrd/image.go	78.94% <0%> (+3.94%)	⬆️
apis/server/utils.go	66.66% <0%> (+4.76%)	⬆️

[HusterWan]

actually, we should add container lock here when we visit container object

[knightXun]

that's not a problem, i think

[pouchrobot]

@knightXun Thanks for your contribution. 🍻
Please sign off in each of your commits.

[allencloud]

Thanks a lot for your contribution. @knightXun Here I have a little bit confusion for you:

RestartCount counts all restart counts of a container including manual restart from user's trigger and restart from restart policy; or just from restart policy?

[knightXun]

@allencloud yeah,manual restart should also be counted.

[allencloud]

LGTM

[allencloud]

Thanks a lot for your contribution. @knightXun This is quite fantastic for us. What is more, could you provide your email address to me? Maybe in the future, we could have more communication.

[knightXun]

@allencloud [email protected], that's my email. thanks