Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add runtime format in config doc #2110

Merged
merged 1 commit into from
Aug 20, 2018
Merged

docs: add runtime format in config doc #2110

merged 1 commit into from
Aug 20, 2018

Conversation

Ace-Tang
Copy link
Contributor

add format example in docs, or user may confused how to
add runtime in config file. Also add this for
docs/features/pouch_with_kata.md and docs/features/pouch_with_runV.md.

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes: #2094

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

add format example in docs, or user may confused how to
add runtime in config file. Also add this for
docs/features/pouch_with_kata.md and docs/features/pouch_with_runV.md.

fixes: #2094.

Signed-off-by: Ace-Tang <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #2110 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2110      +/-   ##
==========================================
+ Coverage   65.09%   65.13%   +0.04%     
==========================================
  Files         208      208              
  Lines       16411    16411              
==========================================
+ Hits        10682    10690       +8     
+ Misses       4399     4392       -7     
+ Partials     1330     1329       -1
Flag Coverage Δ
#criv1alpha1test 33.15% <ø> (-0.16%) ⬇️
#criv1alpha2test 33.94% <ø> (-0.01%) ⬇️
#integrationtest 39.84% <ø> (+0.04%) ⬆️
#unittest 23.87% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha1/cri.go 63.44% <0%> (-0.35%) ⬇️
daemon/mgr/container.go 56.3% <0%> (+0.2%) ⬆️
ctrd/image.go 78.94% <0%> (+2.19%) ⬆️
ctrd/watch.go 80.3% <0%> (+4.54%) ⬆️

@HusterWan
Copy link
Contributor

lgtm

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 20, 2018
@HusterWan HusterWan merged commit 8eb612e into AliyunContainerService:master Aug 20, 2018
@Ace-Tang Ace-Tang deleted the doc_runtime branch August 23, 2018 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pouch start fail cause unknown flag "path" in runtime config
4 participants