bugfix: make rpm package script works #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuweid
changed the title
fuweid
suggested changes
Aug 15, 2018
| hack/install/install_runc.sh | ||
|
|
||
| .PHONY: download-dependencies | ||
| download-dependencies: package-dependencies ## install dumb-init, local-persist, nsenter and CI tools dependencies |
There was a problem hiding this comment.
I think we should change .travis.yml or .circle.yml
There was a problem hiding this comment.
sure, I have updated .travis.yml with Makefile changes.
chuanchang
force-pushed
the
fix_package_issue
branch
2 times, most recently
from
75513c2 to
6337ee7
Compare
Makefile: split download-dependencies into package-dependencies and
download-dependencies for reusing codes in packaging.
.travis.yml:
hack/package/rpm/build.sh: synchronize changes with Makefile
Signed-off-by: Alex Jia <[email protected]>
chuanchang
force-pushed
the
fix_package_issue
branch
from
6337ee7 to
9c3d7db
Compare
Codecov Report
@@ Coverage Diff @@
## master #2100 +/- ##
==========================================
+ Coverage 65.14% 65.17% +0.03%
==========================================
Files 208 208
Lines 16407 16407
==========================================
+ Hits 10688 10694 +6
+ Misses 4388 4385 -3
+ Partials 1331 1328 -3
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile: split download-dependencies into package-dependencies and
download-dependencies for reusing codes in packaging.
hack/package/rpm/build.sh: synchronize Makefile changes
Signed-off-by: Alex Jia [email protected]
Ⅰ. Describe what this PR did
as summary
Ⅱ. Does this pull request fix one issue?
None
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None
Ⅳ. Describe how to verify it
https://github.com/alibaba/pouch/tree/master/hack/package
Ⅴ. Special notes for reviews