bugfix: populate volume error #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HusterWan
reviewed
Aug 14, 2018
| @@ -0,0 +1,120 @@ | |||
| package archive | |||
There was a problem hiding this comment.
Please add unit-test for this package, thanks a lot!
allencloud
reviewed
Aug 14, 2018
pkg/archive/archive.go
Outdated
| func tarFromDir(src string, writer io.Writer) error { | ||
| // ensure the src actually exists before trying to tar it | ||
| if _, err := os.Stat(src); err != nil { | ||
| return fmt.Errorf("Unable to tar files - %v", err.Error()) |
There was a problem hiding this comment.
fmt.Errorf("failed to stat source file %s: %v", src, err)?
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
- Coverage 65.35% 65.29% -0.07%
==========================================
Files 207 208 +1
Lines 16226 16292 +66
==========================================
+ Hits 10605 10638 +33
- Misses 4311 4330 +19
- Partials 1310 1324 +14
|
allencloud
previously requested changes
Aug 14, 2018
pkg/archive/archive.go
Outdated
|
|
||
| // copy file data into tar writer | ||
| if _, err := io.Copy(tw, f); err != nil { | ||
| return err |
There was a problem hiding this comment.
I think before return err, we need to close the file, since it is already open. Otherwise there will be fd leak.
pkg/archive/archive.go
Outdated
| } | ||
|
|
||
| if _, err := io.Copy(f, tr); err != nil { | ||
| return err |
There was a problem hiding this comment.
same issue.
I think before return err, we need to close the file, since it is already open. Otherwise there will be fd leak.
shaloulcy
force-pushed
the
bugfix_for_populate_volume
branch
from
166350f to
74bc39b
Compare
|
I have update the codes, PTAL |
shaloulcy
force-pushed
the
bugfix_for_populate_volume
branch
from
74bc39b to
63e2be2
Compare
Signed-off-by: Eric Li <[email protected]>
shaloulcy
force-pushed
the
bugfix_for_populate_volume
branch
from
63e2be2 to
c2186ef
Compare
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Li [email protected]
Ⅰ. Describe what this PR did
fix populate volume error
Ⅱ. Does this pull request fix one issue?
fixed #2084
Ⅲ. Describe how you did it
copy directory through tar and untar
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews