Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused code from storage #2079

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Aug 13, 2018

Ⅰ. Describe what this PR did

remove unuse code in storage module.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang [email protected]

remove unuse code in storage module.
and add unit-test for storage module.

Signed-off-by: Rudy Zhang <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #2079 into master will increase coverage by 25.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2079       +/-   ##
===========================================
+ Coverage   39.41%   64.91%   +25.49%     
===========================================
  Files         212      209        -3     
  Lines       16462    16227      -235     
===========================================
+ Hits         6488    10533     +4045     
+ Misses       8955     4378     -4577     
- Partials     1019     1316      +297
Flag Coverage Δ
#criv1alpha1test 33.3% <ø> (+25.07%) ⬆️
#criv1alpha2test 33.9% <ø> (?)
#integrationtest 39.93% <ø> (+0.52%) ⬆️
#unittest 23.81% <ø> (?)
Impacted Files Coverage Δ
storage/volume/types/meta/meta.go 0% <ø> (ø) ⬆️
storage/volume/types/volume_util.go 62.5% <ø> (+46.67%) ⬆️
ctrd/image.go 76.75% <0%> (-0.44%) ⬇️
daemon/mgr/container_storage.go 49.48% <0%> (+0.51%) ⬆️
daemon/daemon.go 58.79% <0%> (+1.09%) ⬆️
daemon/mgr/container.go 55.45% <0%> (+2.26%) ⬆️
pkg/meta/store.go 59.52% <0%> (+2.38%) ⬆️
apis/server/utils.go 66.66% <0%> (+2.38%) ⬆️
pkg/user/user.go 75.75% <0%> (+3.03%) ⬆️
daemon/mgr/image_utils.go 85.45% <0%> (+3.63%) ⬆️
... and 99 more

@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit 6a8b3be into AliyunContainerService:master Aug 13, 2018
@allencloud allencloud changed the title refactor: remove unuse code refactor: remove unused code from storage Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants