test: add test cases about CRI image #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starnop
force-pushed
the
cri-test-ImageUser
branch
from
ed387e4 to
947ad03
Compare
|
CI fails: |
starnop
force-pushed
the
cri-test-ImageUser
branch
from
947ad03 to
636692f
Compare
starnop
force-pushed
the
cri-test-ImageUser
branch
from
636692f to
ea1ec36
Compare
Codecov Report
@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
+ Coverage 59.63% 64.77% +5.14%
==========================================
Files 208 208
Lines 16482 16482
==========================================
+ Hits 9829 10677 +848
+ Misses 5453 4474 -979
- Partials 1200 1331 +131
|
|
any update and review? @YaoZengzeng |
YaoZengzeng
reviewed
Aug 20, 2018
cri/v1alpha2/cri_utils_test.go
Outdated
| Username: "foo", | ||
| Volumes: parseVolumesFromPouch(map[string]interface{}{"foo": "foo"}), | ||
| }, | ||
| wantErr: nil, |
There was a problem hiding this comment.
The type of wantErr is bool, we could not assign nil to it.
CI has found this mistake but not failed.
cri/v1alpha2/cri_utils_test.go
Outdated
| imageUser: "", | ||
| }, | ||
| want: nil, | ||
| want1: "", |
There was a problem hiding this comment.
Use a better name, other than want1 :)
cri/v1alpha2/cri_utils_test.go
Outdated
| args: args{ | ||
| imageUser: "", | ||
| }, | ||
| want: nil, |
There was a problem hiding this comment.
We should check whether the value is equal other then the pointer.
There was a problem hiding this comment.
Thanks for your comment. All above mentioned has been done.
starnop
force-pushed
the
cri-test-ImageUser
branch
3 times, most recently
from
b598225 to
f195bae
Compare
|
CRI unit test fails, @starnop : |
starnop
force-pushed
the
cri-test-ImageUser
branch
4 times, most recently
from
36be0d5 to
efd1dbd
Compare
Signed-off-by: Starnop <[email protected]>
starnop
force-pushed
the
cri-test-ImageUser
branch
from
efd1dbd to
796d025
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes part of #1756
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews