Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit-test for getSELinuxSecurityOpts method which locate on cri/v… #2023

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

Coordinate36
Copy link
Contributor

…1alpha1/cri_utils.go

Signed-off-by: Coordinate36 [email protected]

Ⅰ. Describe what this PR did

Add unit-test for getSELinuxSecurityOpts method which locate on cri/v1alpha1/cri_utils.go.

Ⅱ. Does this pull request fix one issue?

fixes #1912

Ⅲ. Describe how you did it

Build unit test by condition combination coverage(ccc).
First, build program structure graph. According to the graph and the principle of ccc, we derive the test cases

Ⅳ. Describe how to verify it

cd cri/v1alpha1; go test.

Ⅴ. Special notes for reviews

no

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @Coordinate36
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pouchrobot
Copy link
Collaborator

ping @Coordinate36
We found that this PR is 22 commits, which is more than 10 commits, behind master.
Please rebase the branch against master and push it back again. Thanks a lot.

@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #2023 into master will decrease coverage by 4.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2023      +/-   ##
==========================================
- Coverage   63.31%   58.54%   -4.77%     
==========================================
  Files         200      200              
  Lines       15522    15522              
==========================================
- Hits         9828     9088     -740     
- Misses       4455     5127     +672     
- Partials     1239     1307      +68
Flag Coverage Δ
#criv1alpha1test 33.79% <ø> (-0.06%) ⬇️
#criv1alpha2test 34.27% <ø> (-0.01%) ⬇️
#integrationtest 38.39% <ø> (-0.05%) ⬇️
#unittest 18.96% <ø> (-1.9%) ⬇️
Impacted Files Coverage Δ
pkg/multierror/def.go 15.38% <0%> (-84.62%) ⬇️
daemon/logger/loggerutils/tag.go 0% <0%> (-81.82%) ⬇️
pkg/utils/utils.go 25.64% <0%> (-64.53%) ⬇️
pkg/bytefmt/bytefmt.go 28.81% <0%> (-64.41%) ⬇️
ctrd/image_proxy_util.go 7.81% <0%> (-59.38%) ⬇️
daemon/mgr/container_envs.go 11.76% <0%> (-54.91%) ⬇️
daemon/logger/info.go 0% <0%> (-53.66%) ⬇️
daemon/logger/syslog/validate.go 0% <0%> (-52.64%) ⬇️
pkg/utils/filters/filter.go 22.5% <0%> (-50%) ⬇️
pkg/utils/templates/templates.go 0% <0%> (-50%) ⬇️
... and 28 more

@allencloud allencloud changed the title Add unit-test for getSELinuxSecurityOpts method which locate on cri/v… test: add unit-test for getSELinuxSecurityOpts method which locate on cri/v… Aug 1, 2018
@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit a8b6b19 into AliyunContainerService:master Aug 1, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test gap/needs-rebase LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for getSELinuxSecurityOpts
5 participants