Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test_imageToCriImage #1990

Merged
merged 3 commits into from
Aug 1, 2018
Merged

Test_imageToCriImage #1990

merged 3 commits into from
Aug 1, 2018

Conversation

KevinLeung611
Copy link

Ⅰ. Describe what this PR did

add unit-test for imageToCriImage

Ⅱ. Does this pull request fix one issue?

fix issue #1914

Ⅲ. Describe how you did it

  1. understand what the imageToImage method does.
  2. add some args that the imageToImage method needs
  3. go test

Ⅳ. Describe how to verify it

verify User, including "", numeric string, string, contains ":"
verify Uid, if user is numeric string, whether the uid is correct
verify ID, numeric string and common string
verify RepoTags, common string
verify RepoDigests, common string
verify Size_, common int64

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


shanbo.lkw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @KevinLeung-nice
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@KevinLeung611 KevinLeung611 changed the title Image to cri image test Test_imageToCriImage Jul 31, 2018
Signed-off-by: shanbo.lkw <[email protected]>
@pouchrobot
Copy link
Collaborator

@KevinLeung-nice Thanks for your contribution. 🍻
Please sign off in each of your commits.

@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #1990 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
+ Coverage   63.31%   63.36%   +0.04%     
==========================================
  Files         200      200              
  Lines       15522    15522              
==========================================
+ Hits         9828     9835       +7     
+ Misses       4455     4448       -7     
  Partials     1239     1239
Flag Coverage Δ
#criv1alpha1test 33.82% <ø> (-0.03%) ⬇️
#criv1alpha2test 34.28% <ø> (ø) ⬆️
#integrationtest 38.44% <ø> (ø) ⬆️
#unittest 21.26% <ø> (+0.4%) ⬆️
Impacted Files Coverage Δ
ctrd/watch.go 72.72% <0%> (-3.04%) ⬇️
cri/v1alpha1/cri_utils.go 75.89% <0%> (+1.6%) ⬆️

@fuweid fuweid merged commit 463246a into AliyunContainerService:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants