Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit test for cri/stream/errors.go #1909

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

YaoZengzeng
Copy link
Contributor

Signed-off-by: YaoZengzeng [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

#1756

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/M labels Jul 26, 2018
@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #1909 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1909      +/-   ##
==========================================
+ Coverage   62.54%   62.67%   +0.12%     
==========================================
  Files         200      200              
  Lines       15567    15567              
==========================================
+ Hits         9737     9757      +20     
+ Misses       4580     4566      -14     
+ Partials     1250     1244       -6
Flag Coverage Δ
#criv1alpha1test 33.26% <ø> (+0.05%) ⬆️
#criv1alpha2test 33.74% <ø> (-0.02%) ⬇️
#integrationtest 37.88% <ø> (-0.02%) ⬇️
#unittest 20.4% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
ctrd/image.go 76.73% <0%> (-4.46%) ⬇️
cri/v1alpha2/cri.go 66.13% <0%> (+0.17%) ⬆️
cri/v1alpha1/cri.go 65.22% <0%> (+0.18%) ⬆️
daemon/mgr/container.go 53.46% <0%> (+0.31%) ⬆️
ctrd/container.go 50.17% <0%> (+0.68%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
cri/stream/httpstream/spdy/upgrade.go 60% <0%> (+5.71%) ⬆️
cri/stream/errors.go 100% <0%> (+100%) ⬆️

@starnop
Copy link
Contributor

starnop commented Jul 30, 2018

LGTM.

@allencloud allencloud merged commit 85df96b into AliyunContainerService:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants