Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit test for cri/stream/httpstream/httpstream.go #1892

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

YaoZengzeng
Copy link
Contributor

Signed-off-by: YaoZengzeng [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes part of #1756

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #1892 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
+ Coverage   58.68%   58.77%   +0.08%     
==========================================
  Files         200      200              
  Lines       15565    15565              
==========================================
+ Hits         9135     9149      +14     
+ Misses       5143     5131      -12     
+ Partials     1287     1285       -2
Flag Coverage Δ
#criv1alpha1test 33.29% <ø> (+0.08%) ⬆️
#criv1alpha2test 33.49% <ø> (-0.31%) ⬇️
#integrationtest 37.93% <ø> (+0.03%) ⬆️
#unittest 13.82% <ø> (+0.39%) ⬆️
Impacted Files Coverage Δ
cri/stream/httpstream/spdy/upgrade.go 54.28% <0%> (-5.72%) ⬇️
cri/stream/httpstream/httpstream.go 96.29% <0%> (+59.25%) ⬆️

@YaoZengzeng
Copy link
Contributor Author

@allencloud @fuweid PTAL.

@YaoZengzeng
Copy link
Contributor Author

@starnop PTAL

@starnop
Copy link
Contributor

starnop commented Jul 31, 2018

LGTM.

@allencloud allencloud merged commit fe7fbd6 into AliyunContainerService:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants