Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit-test for daemon/config/getConfigurations #1851

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jul 24, 2018

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1759

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@SeaRise Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @SeaRise
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@@ -4,6 +4,8 @@ import (
"testing"

"github.com/stretchr/testify/assert"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this blank line

@zhuangqh
Copy link
Contributor

LGTM

@zhuangqh zhuangqh added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 24, 2018
@allencloud allencloud merged commit 34ebc3f into AliyunContainerService:master Jul 24, 2018
@allencloud allencloud changed the title add unit-test for daemon/config/getConfigurations team4 test: add unit-test for daemon/config/getConfigurations Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for daemon/config/getConfigurations
4 participants