Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for func storage/volume/ListVolumeName #1810

Merged

Conversation

btlcmr0702
Copy link
Contributor

Ⅰ. Describe what this PR did

add unit test for func storage/volume/ListVolumeName at core_test.go

Ⅱ. Does this pull request fix one issue?

YES, for #1763

Ⅲ. Describe how you did it

Get all the name of volume by the func ListVolumeName and then try to find whether they are the same with name of volume.

Ⅳ. Describe how to verify it

Run go test at dir storage/volume

Ⅴ. Special notes for reviews

TEAM 10
baiji developers

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @btlcmr0702
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@btlcmr0702 btlcmr0702 force-pushed the baiji_eiai_issue_1763 branch from fa73c81 to 66aac93 Compare July 24, 2018 01:36
@codecov-io
Copy link

Codecov Report

Merging #1810 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
+ Coverage    56.3%   56.42%   +0.12%     
==========================================
  Files         200      200              
  Lines       15657    15657              
==========================================
+ Hits         8816     8835      +19     
+ Misses       5745     5730      -15     
+ Partials     1096     1092       -4
Flag Coverage Δ
#critest 33.5% <ø> (+0.02%) ⬆️
#integrationtest 37.67% <ø> (+0.01%) ⬆️
#unittest 20.37% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
cri/v1alpha2/cri.go 66.13% <0%> (+0.17%) ⬆️
daemon/mgr/container.go 53.46% <0%> (+0.31%) ⬆️
ctrd/container.go 50.17% <0%> (+1.37%) ⬆️
daemon/mgr/system.go 76.72% <0%> (+1.72%) ⬆️
ctrd/image.go 78.71% <0%> (+1.98%) ⬆️
storage/volume/core.go 62.43% <0%> (+2.92%) ⬆️

@btlcmr0702 btlcmr0702 changed the title test: add unit test for func storage/volume/ListVolumeName # 1763 test: add unit test for func storage/volume/ListVolumeName Jul 24, 2018
@sunyuan3 sunyuan3 merged commit 0f90013 into AliyunContainerService:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants