bugfix: pull non-exist image in container create #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1764 +/- ##
==========================================
+ Coverage 56.3% 56.33% +0.02%
==========================================
Files 200 200
Lines 15657 15659 +2
==========================================
+ Hits 8816 8821 +5
+ Misses 5745 5744 -1
+ Partials 1096 1094 -2
|
|
Please add an integration test in the CI, so that this case could be covered forever. Thanks a lot. |
allencloud
reviewed
Jul 23, 2018
| @@ -60,6 +60,10 @@ func (cc *CreateCommand) runCreate(args []string) error { | |||
|
|
|||
| ctx := context.Background() | |||
| apiClient := cc.cli.Client() | |||
| if err := pullMissingImage(ctx, apiClient, config.Image, false); err != nil { | |||
There was a problem hiding this comment.
The best will be done in api server, hope someone can do that.
There was a problem hiding this comment.
@allencloud @Ace-Tang I don't think it should be done in the API server, because we don't know the client want to pull the missing image and it will make the API heavy. Currently, the Pull API allows the caller to do the customize like pullMissingImage. It's good enough, I think.
There was a problem hiding this comment.
As you said, @fuweid , one api just do one thing, seems make sense.
fuweid
suggested changes
Jul 23, 2018
Signed-off-by: Ace-Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ace-Tang [email protected]
Ⅰ. Describe what this PR did
Pull image if not exist in container create process.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews