test: add api tests for some commands #1747

xiechengsheng · 2018-07-17T13:14:00Z

Signed-off-by: xiechengsheng [email protected]

Ⅰ. Describe what this PR did

add api tests for some commands.

add state check in api pause test.
add remove image case in api rmi test.
add api test for image load and save functionality.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Thanks for @fuweid 's help.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-io · 2018-07-19T11:18:31Z

Codecov Report

Merging #1747 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
- Coverage    62.8%   62.72%   -0.09%     
==========================================
  Files         200      200              
  Lines       15567    15567              
==========================================
- Hits         9777     9764      -13     
- Misses       4544     4552       +8     
- Partials     1246     1251       +5

Flag	Coverage Δ
#criv1alpha1test	`33.24% <ø> (-0.04%)`	⬇️
#criv1alpha2test	`33.73% <ø> (ø)`	⬆️
#integrationtest	`37.9% <ø> (-0.03%)`	⬇️
#unittest	`20.7% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
apis/server/utils.go	`61.9% <0%> (-4.77%)`	⬇️
daemon/logger/jsonfile/utils.go	`71.54% <0%> (-1.63%)`	⬇️
ctrd/container.go	`48.79% <0%> (-1.38%)`	⬇️
daemon/mgr/container.go	`53.69% <0%> (-0.32%)`	⬇️
cri/v1alpha1/cri.go	`65.04% <0%> (-0.19%)`	⬇️

xiechengsheng · 2018-07-20T03:17:02Z

cc @fuweid PTAL, thanks.

fuweid

It seems that the change is not only for load and save. Could you mind to change the git message and the PR title? Thanks

fuweid · 2018-07-23T10:21:14Z

test/api_image_save_and_load_test.go

+	loadImageName := "load-helloworld"
+	q = url.Values{}
+	q.Set("name", loadImageName)
+	q.Set("quiet", "0")


I don't think we support the quiet query here 😄

yes, you are right.

fuweid · 2018-07-23T10:25:01Z

test/api_image_save_and_load_test.go

+	query := request.WithQuery(q)
+	resp, err := request.Get("/images/save", query)
+	c.Assert(err, check.IsNil)
+	defer resp.Body.Close()


could we use the tmpfile to store the intermediate result? It seems that it is tricky to use one response body as other request body. 😄

ok, will done soon.

I mean that save the body data into tmpFile not the var

@fuweid I don't think we should create a new file to store the response data stream, because this is a API test, not client test. In API test I think we handle the http response data is enough. And both save and load commands handle the data stream to tar file(or tar file to data stream) in client side, not the http response side. And in other API test, such as api_image_inspect_test and api_container_inspect_test, we just use the HTTP response data to check the correctness of this API function. WDYT?

client test includes the api test, I think. cli wrap the client to provide better UEX. for this cases, the api test is same to the cli test. However, you connect two http connections, which is pretty hacking in testing. So I want to save the data in the local and send it again.

chuanchang · 2018-07-24T09:24:25Z

It works for me.

xiechengsheng · 2018-07-28T08:45:46Z

@fuweid Have fixed all bugs, PTAL again, thanks a lot~

fuweid · 2018-07-30T03:23:13Z

test/api_image_save_and_load_test.go

+	query := request.WithQuery(q)
+	resp, err := request.Get("/images/save", query)
+	c.Assert(err, check.IsNil)
+	defer resp.Body.Close()


I mean that save the body data into tmpFile not the var

Signed-off-by: xiechengsheng <[email protected]>

allencloud · 2018-07-30T06:18:06Z

Unfortunately, The code check CI fails:

gometalinter
gometalinter --config .gometalinter.json ./...
test/api_image_save_and_load_test.go:1::warning: file is not gofmted with -s (gofmt)
test/api_image_save_and_load_test.go:1::warning: file is not goimported (goimports)
Makefile:122: recipe for target 'gometalinter' failed
make: *** [gometalinter] Error 1

pity 📡 @xiechengsheng

xiechengsheng · 2018-07-30T06:22:52Z

Yes, just now this pr fails on code check, it's my mistake.
@fuweid Have updated codes according to your meaning, PTAL, thanks~

xiechengsheng · 2018-08-01T07:33:42Z

@fuweid Please take a look this pr, thanks a lot~

fuweid

LGTM

pouchrobot added areas/test size/L labels Jul 17, 2018

xiechengsheng force-pushed the add-test branch 6 times, most recently from 17173e5 to 863e968 Compare July 19, 2018 10:42

allencloud assigned chuanchang Jul 23, 2018

fuweid reviewed Jul 23, 2018

View reviewed changes

xiechengsheng force-pushed the add-test branch from 863e968 to 34476e5 Compare July 23, 2018 11:13

xiechengsheng changed the title ~~test: add api test for image load and save~~ test: add api tests for some commands Jul 23, 2018

pouchrobot added the areas/cli label Jul 23, 2018

allencloud assigned chuanchang and fuweid and unassigned chuanchang Jul 29, 2018

fuweid suggested changes Jul 30, 2018

View reviewed changes

xiechengsheng force-pushed the add-test branch from 34476e5 to 9f3ca3b Compare July 30, 2018 06:10

pouchrobot added size/XL and removed size/L labels Jul 30, 2018

test: add api tests for some commands

1fd2587

Signed-off-by: xiechengsheng <[email protected]>

xiechengsheng force-pushed the add-test branch from 9f3ca3b to 1fd2587 Compare July 30, 2018 06:19

fuweid approved these changes Aug 1, 2018

View reviewed changes

fuweid merged commit 5ed312e into AliyunContainerService:master Aug 1, 2018

pouchrobot mentioned this pull request Aug 2, 2018

Weekly Report of PouchContainer from 2018-07-26 to 2018-08-02 #2036

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add api tests for some commands #1747

test: add api tests for some commands #1747

xiechengsheng commented Jul 17, 2018 •

edited

Loading

codecov-io commented Jul 19, 2018 •

edited

Loading

xiechengsheng commented Jul 20, 2018

fuweid left a comment

fuweid Jul 23, 2018

xiechengsheng Jul 23, 2018

fuweid Jul 23, 2018

xiechengsheng Jul 23, 2018

fuweid Jul 30, 2018

xiechengsheng Jul 30, 2018

fuweid Jul 30, 2018

chuanchang commented Jul 24, 2018

xiechengsheng commented Jul 28, 2018

fuweid Jul 30, 2018

allencloud commented Jul 30, 2018

xiechengsheng commented Jul 30, 2018

xiechengsheng commented Aug 1, 2018

fuweid left a comment

test: add api tests for some commands #1747

test: add api tests for some commands #1747

Conversation

xiechengsheng commented Jul 17, 2018 • edited Loading

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-io commented Jul 19, 2018 • edited Loading

Codecov Report

xiechengsheng commented Jul 20, 2018

fuweid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chuanchang commented Jul 24, 2018

xiechengsheng commented Jul 28, 2018

Choose a reason for hiding this comment

allencloud commented Jul 30, 2018

xiechengsheng commented Jul 30, 2018

xiechengsheng commented Aug 1, 2018

fuweid left a comment

Choose a reason for hiding this comment

xiechengsheng commented Jul 17, 2018 •

edited

Loading

codecov-io commented Jul 19, 2018 •

edited

Loading