-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: populate empty volumes when creating container #1745
Merged
rudyfly
merged 1 commit into
AliyunContainerService:master
from
shaloulcy:populate_volume
Jul 19, 2018
Merged
feature: populate empty volumes when creating container #1745
rudyfly
merged 1 commit into
AliyunContainerService:master
from
shaloulcy:populate_volume
Jul 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaloulcy
force-pushed
the
populate_volume
branch
6 times, most recently
from
July 17, 2018 15:37
7bf8568
to
7e187e6
Compare
Signed-off-by: Eric Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1745 +/- ##
==========================================
- Coverage 14.14% 14.13% -0.02%
==========================================
Files 281 281
Lines 56728 56797 +69
==========================================
- Hits 8027 8026 -1
- Misses 47777 47838 +61
- Partials 924 933 +9
|
shaloulcy
force-pushed
the
populate_volume
branch
from
July 17, 2018 16:13
7e187e6
to
8cb3d14
Compare
I've tested this PR on my local machine, it works fine. |
I think this could definitely add an integration test. WDYT? @shaloulcy @YaoZengzeng |
@YaoZengzeng Are you interested to add an integration test? thanks~ |
@shaloulcy After this PR being merged, I'll write a test for it. |
LGTM |
pouchrobot
added
the
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
label
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
areas/storage
kind/feature
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Li [email protected]
Ⅰ. Describe what this PR did
if the volume is empty and image path is not empty, we will populate the volume with the image data
Ⅱ. Does this pull request fix one issue?
fixes #1739
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews