enhance: add .DS_Store ignore #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Frankzhaopku Thanks for your contribution. 🍻 |
fuweid
reviewed
Jul 12, 2018
| @@ -8,3 +8,4 @@ coverage.txt | |||
| .editorconfig | |||
| .bashrc | |||
| .idea | |||
| .DS_Store | |||
There was a problem hiding this comment.
*/.DS_Store is better for any dir in the root. WDTY?
There was a problem hiding this comment.
@fuweid Actually .DS_Store already ignored all the files in sub directories, if this is what you mean.
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
=========================================
- Coverage 41.26% 41.2% -0.06%
=========================================
Files 274 274
Lines 18123 18123
=========================================
- Hits 7478 7468 -10
- Misses 9733 9740 +7
- Partials 912 915 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add .DS_Store file ignore pattern in .gitignore to prevent contributor commit these files.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews