bugfix: we should set Running flag to true when started container #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1604 +/- ##
==========================================
- Coverage 41.64% 41.48% -0.16%
==========================================
Files 268 271 +3
Lines 17408 17568 +160
==========================================
+ Hits 7249 7288 +39
- Misses 9263 9381 +118
- Partials 896 899 +3
|
Ace-Tang
reviewed
Jun 28, 2018
daemon/mgr/container_state.go
Outdated
| @@ -90,6 +90,7 @@ func (c *Container) SetStatusRunning(pid int64) { | |||
| c.State.StartedAt = time.Now().UTC().Format(utils.TimeLayout) | |||
| c.State.Pid = pid | |||
| c.State.ExitCode = 0 | |||
| c.State.Running = true | |||
There was a problem hiding this comment.
Do we need to set c.State.Running to flase when container stop?
There was a problem hiding this comment.
Good point, i will optimize soon
Signed-off-by: Michael Wan <[email protected]>
Ace-Tang
reviewed
Jun 28, 2018
| @@ -133,4 +137,33 @@ func (c *Container) SetStatusUnpaused() { | |||
| c.Lock() | |||
| defer c.Unlock() | |||
| c.State.Status = types.StatusRunning | |||
| c.setStatusFlags(types.StatusRunning) | |||
There was a problem hiding this comment.
I just wonder why use a function instead of a single line like c.State.Running=true ?
There was a problem hiding this comment.
we have 4 flags : Dead, Paused, Restarting and Running , the flags are exclusive，so when set one flag, we should unset others. WDYT? @Ace-Tang
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan [email protected]
Ⅰ. Describe what this PR did
SetStatusset Running flag to true when started a containerⅡ. Does this pull request fix one issue?
fixes #1602
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews