feature: add systemd notify #1577
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
- Coverage 41.54% 40.65% -0.89%
==========================================
Files 267 267
Lines 17375 17792 +417
==========================================
+ Hits 7218 7233 +15
- Misses 9264 9666 +402
Partials 893 893
|
For the case that systemctl start pouch, we need to make sure that the pouchd has been started successfully. We cannot rely on the exit code of systemctl only, we need to use NOTIFY_SOCKET to send the state to the systemd. Signed-off-by: Eric Li <[email protected]>
shaloulcy
force-pushed
the
notify_systemd
branch
from
eee7098 to
270bbc5
Compare
| httpReady := <-httpReadyCh | ||
| criReady := <-criReadyCh | ||
|
|
||
| if httpReady && criReady { |
There was a problem hiding this comment.
cri manager may don't start if enable-cri=false is specified, is it ok in this case?
There was a problem hiding this comment.
it's ok. If enable-cri=false is specified, we can read true from thehttpReadyCh
|
ping @shaloulcy |
|
LGTM. Since we don't have the adaptor to handle different servers, next step we can make it elegant. |
|
But I need to confirm the version of dependency because it is different from |
|
Confirm. We can merge it |
For the case that systemctl start pouch, we need to make sure that the
pouchd has been started successfully. We cannot rely on the exit code
of systemctl only, we need to use NOTIFY_SOCKET to send the state to
the systemd.
Ⅰ. Describe what this PR did
For the case that systemctl start pouch, we need to make sure that the pouchd has been started successfully. We cannot rely on the exit code of systemctl only, we need to use NOTIFY_SOCKET to send the state to the systemd.
So when the pouchd has set up , it will send the state to systemd
Ⅱ. Does this pull request fix one issue?
fixes #1568
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews