-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: enable non-root user to run pouch commands without sudo #1573
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
===========================================
- Coverage 40.84% 17.89% -22.95%
===========================================
Files 274 223 -51
Lines 18089 14711 -3378
===========================================
- Hits 7389 2633 -4756
- Misses 9787 11907 +2120
+ Partials 913 171 -742
|
INSTALLATION.md
Outdated
|
||
**1. create the pouch group** | ||
|
||
If you want to unix socket to be owned by pouch group, make sure it exist or create it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
If you want the unix socket to be owned by pouch group, make sure it exists or you need to create it.
INSTALLATION.md
Outdated
@@ -126,6 +126,32 @@ sudo systemctl start pouch | |||
|
|||
Afterwards, you can pull an image and run PouchContainer containers. | |||
|
|||
## Run pouch command with non-root users | |||
|
|||
To enable users other than root can run pouch command directly without `sudo`, pouchd creates a unix socket owned by pouch group. Users just need have pouch group on the machine and add user to pouch group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need have -> need to have
Good advice, updated, PTAL, @Letty5411 |
README.md
Outdated
@@ -66,7 +67,7 @@ PouchContainer offers a more "application centric" approach for application deve | |||
|
|||
## Getting Started | |||
|
|||
You can easily setup a basic PouchContainer environment, see [INSTALLATION.md](INSTALLATION.md). You'll need to install a few packages before starting `pouchd`, which starts a container management service. The service can be accessed through the `pouch` CLI or RPC calls. For more details, please refer to [CLI Manual](docs/commandline) and [API Manual](docs/api). | |||
You can easily setup a basic PouchContainer environment, see [INSTALLATION.md](INSTALLATION.md). You'll need to install a few packages before starting `pouchd`, which starts a container management service. The service can be accessed through the `pouch` CLI or RPC calls. For more details, please refer to [CLI Manual](docs/commandline), [API Manual](docs/api)and [USER Manual](docs/user). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
miss a space here.
...api)and [USER Manual](docs/user)
↑
enable non-root user to run pouch commands without sudo Signed-off-by: Ace-Tang <[email protected]>
PTAL, @Letty5411 @zhuangqh |
LGTM |
Signed-off-by: Ace-Tang [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews