refactor: refactor container update diskquota type #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HusterWan
reviewed
Jun 21, 2018
apis/plugins/ContainerPlugin.go
Outdated
| @@ -16,4 +16,8 @@ type ContainerPlugin interface { | |||
| // and if this endpoint should enable resolver and a map which will be used as generic params to create endpoints of | |||
| // this container | |||
| PreCreateEndpoint(string, []string) (priority int, disableResolver bool, genericParam map[string]interface{}) | |||
|
|
|||
| // PreUpdate defines plugin point where receives an container update request, in this plugin point user | |||
allencloud
reviewed
Jun 21, 2018
cli/update.go
Outdated
| @@ -52,7 +51,7 @@ func (uc *UpdateCommand) addFlags() { | |||
| flagSet.StringSliceVarP(&uc.env, "env", "e", nil, "Set environment variables for container") | |||
| flagSet.StringSliceVarP(&uc.labels, "label", "l", nil, "Set label for container") | |||
| flagSet.StringVar(&uc.restartPolicy, "restart", "", "Restart policy to apply when container exits") | |||
| flagSet.StringVar(&uc.quota, "quota", "", "Update disk quota for container") | |||
| flagSet.StringSliceVar(&uc.diskQuota, "disk-quota", nil, "Update disk quota for container") | |||
There was a problem hiding this comment.
I think we should add more details here in the command line usage. For exapmle, how to unset the original diskquota @rudyfly
HusterWan
reviewed
Jun 21, 2018
cli/update.go
Outdated
| @@ -52,7 +51,7 @@ func (uc *UpdateCommand) addFlags() { | |||
| flagSet.StringSliceVarP(&uc.env, "env", "e", nil, "Set environment variables for container") | |||
| flagSet.StringSliceVarP(&uc.labels, "label", "l", nil, "Set label for container") | |||
| flagSet.StringVar(&uc.restartPolicy, "restart", "", "Restart policy to apply when container exits") | |||
| flagSet.StringVar(&uc.quota, "quota", "", "Update disk quota for container") | |||
| flagSet.StringSliceVar(&uc.diskQuota, "disk-quota", nil, "Update disk quota for container") | |||
There was a problem hiding this comment.
Actually, in cli/common_flag we have already defined the diskQuota , so if we change the type to slice, no need define here.
refactor container update diskquota type, change it from `string` to `map[string]string`, make it consistent with container create api. Signed-off-by: Rudy Zhang <[email protected]>
rudyfly
force-pushed
the
update-diskquota
branch
from
079e680 to
b5d245e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1572 +/- ##
==========================================
- Coverage 41.59% 40.87% -0.73%
==========================================
Files 267 267
Lines 17366 17702 +336
==========================================
+ Hits 7223 7235 +12
- Misses 9251 9574 +323
- Partials 892 893 +1
|
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
refactor container update diskquota type, change it from
stringtomap[string]string, make it consistent with container create api.Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]