test: add all states container restart validation #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
add-command-in-test
branch
from
26ff455 to
f5e9e1d
Compare
allencloud
force-pushed
the
add-command-in-test
branch
from
f5e9e1d to
2da4ead
Compare
Codecov Report
@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
- Coverage 41.21% 39.33% -1.89%
==========================================
Files 266 266
Lines 17313 17968 +655
==========================================
- Hits 7136 7068 -68
- Misses 9290 10022 +732
+ Partials 887 878 -9
|
Letty5411
reviewed
Jun 19, 2018
test/cli_restart_test.go
Outdated
| defer DelContainerForceMultyTime(c, name) | ||
|
|
||
| res.Assert(c, icmd.Success) | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
why this sleep is required? As you don't use -d in line 69, container is expected to be in exited state as soon as it returns, right?
There was a problem hiding this comment.
My fault, I added -d.
Signed-off-by: Allen Sun <[email protected]>
allencloud
force-pushed
the
add-command-in-test
branch
from
2da4ead to
e150e43
Compare
|
LGTM |
pouchrobot
added
the
LGTM
This was referenced Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
This pr changes the test cases for restart action:
2.add containers with all states to check the restart action, like running, exited, stopped, created.
this is similar to #1548
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
@Letty5411