bugfix: fix rpm package bug #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuweid
reviewed
Jun 13, 2018
hack/package/rpm/build.sh
Outdated
| @@ -41,7 +41,7 @@ function build_lxcfs () | |||
| git clone -b "$LXC_BRANCH" https://github.com/lxc/lxcfs.git && cd lxcfs | |||
|
|
|||
| # change liblxcfs.so to libpouchlxcfs.so | |||
| sed -i 's/liblxcfs/libpouchlxcfs/g' "$(grep -r "liblxcfs" . |awk -F':' '{print $1}'|uniq )" | |||
| grep -r "liblxcfs" . |awk -F':' '{print $1}'|uniq | xargs sed -i 's/liblxcfs/libpouchlxcfs/g' | |||
There was a problem hiding this comment.
we can use grep -l -r "liblxcfs" . | xargs sed -i 's/liblxcfs/libpouchlxcfs/g'. 😄 WDYT?
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
===========================================
+ Coverage 16.88% 40.82% +23.94%
===========================================
Files 211 254 +43
Lines 14020 16605 +2585
===========================================
+ Hits 2367 6779 +4412
+ Misses 11490 8958 -2532
- Partials 163 868 +705
|
Signed-off-by: letty <[email protected]>
|
Since the change doesn’t impact the case, I will merge this |
This was referenced Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: letty [email protected]
Ⅰ. Describe what this PR did
fix shell error
Ⅱ. Does this pull request fix one issue?
fix #1509
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews