Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: use the stable image ID in test #1397

Merged
merged 1 commit into from
May 24, 2018
Merged

bugfix: use the stable image ID in test #1397

merged 1 commit into from
May 24, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented May 24, 2018

Signed-off-by: Wei Fu [email protected]

Ⅰ. Describe what this PR did

The busybox:1.28 has been repushed so that the imageID will be changed.
In order to make the test stable, we should use the stable image.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

NONE

Ⅳ. Describe how to verify it

NONE

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/S labels May 24, 2018
@fuweid fuweid requested a review from Letty5411 May 24, 2018 03:24
@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 24, 2018
The busybox:1.28 has been repushed so that the imageID will be changed.
In order to make the test stable, we should use the stable image.

Signed-off-by: Wei Fu <[email protected]>
@codecov-io
Copy link

codecov-io commented May 24, 2018

Codecov Report

Merging #1397 into master will increase coverage by 22.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1397       +/-   ##
===========================================
+ Coverage   16.28%   38.55%   +22.27%     
===========================================
  Files         198      248       +50     
  Lines       13470    16516     +3046     
===========================================
+ Hits         2193     6368     +4175     
+ Misses      11126     9328     -1798     
- Partials      151      820      +669
Impacted Files Coverage Δ
cri/v1alpha1/service/cri.go 0% <0%> (ø)
storage/volume/modules/tmpfs/tmpfs.go 16.39% <0%> (ø)
pkg/serializer/serialize.go 9.52% <0%> (ø)
storage/volume/driver/context.go 8.69% <0%> (ø)
storage/volume/modules/ceph/types.go 0% <0%> (ø)
storage/volume/core_util.go 19.73% <0%> (ø)
cri/stream/errors.go 0% <0%> (ø)
cri/stream/remotecommand/attach.go 0% <0%> (ø)
registry/auth_challenge.go 62.5% <0%> (ø)
storage/volume/core.go 37.13% <0%> (ø)
... and 112 more

@Letty5411 Letty5411 merged commit 61fc289 into AliyunContainerService:master May 24, 2018
@fuweid fuweid deleted the bugfix_use_stable_image_id branch August 3, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants