Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: panic when execute exec command with flag -d #1394

Merged
merged 1 commit into from
May 24, 2018

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan [email protected]

Ⅰ. Describe what this PR did

fix panic when execute exec command with flag -d

Ⅱ. Does this pull request fix one issue?

fixes #1392

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/cli kind/bug This is bug report for project kind/panic priority/P1 this is high priority that all maintainers should stop to handle this issue size/XS labels May 23, 2018
@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #1394 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
- Coverage   38.52%   38.51%   -0.01%     
==========================================
  Files         248      248              
  Lines       16512    16512              
==========================================
- Hits         6361     6360       -1     
- Misses       9331     9332       +1     
  Partials      820      820
Impacted Files Coverage Δ
daemon/mgr/container.go 49.35% <100%> (-0.26%) ⬇️
daemon/containerio/container_io.go 57.79% <0%> (-3.25%) ⬇️
ctrd/container.go 48.06% <0%> (+0.77%) ⬆️
ctrd/image.go 86.07% <0%> (+1.89%) ⬆️
apis/server/utils.go 66.66% <0%> (+5.55%) ⬆️

@fuweid
Copy link
Contributor

fuweid commented May 24, 2018

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli kind/bug This is bug report for project kind/panic priority/P1 this is high priority that all maintainers should stop to handle this issue size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] occurred panic when execute exec with flag -d
4 participants