Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move the code about cri out of mgr #1317

Merged
merged 1 commit into from
May 15, 2018

Conversation

starnop
Copy link
Contributor

@starnop starnop commented May 14, 2018

Ⅰ. Describe what this PR did

move the code about cri out of mgr, in order to decouple.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@starnop Thanks for your contribution. 🍻
Please sign off in each of your commits.

@codecov-io
Copy link

Codecov Report

Merging #1317 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
+ Coverage   17.38%   17.39%   +0.01%     
==========================================
  Files         189      189              
  Lines       11772    11772              
==========================================
+ Hits         2046     2048       +2     
+ Misses       9578     9577       -1     
+ Partials      148      147       -1
Impacted Files Coverage Δ
daemon/config/config.go 7.89% <ø> (ø) ⬆️
cri/src/cri_types.go 0% <ø> (ø)
cri/src/cri_wrapper.go 0% <ø> (ø)
cri/src/cri_network.go 0% <0%> (ø)
cri/src/cri_utils.go 29.31% <0%> (ø)
cri/src/cri.go 0% <0%> (ø)
cri/src/cri_stream.go 0% <0%> (ø)
daemon/logger/jsonfile/utils.go 70% <0%> (+1.66%) ⬆️

@allencloud
Copy link
Collaborator

I am wondering if the folder name src makes sense?

@allencloud
Copy link
Collaborator

LGTM
feel so good to see the cri part decoupled with others. I think in this way, cri team could maintainer it well.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 15, 2018
@allencloud allencloud merged commit a3b0208 into AliyunContainerService:master May 15, 2018
@starnop starnop deleted the cri-refactor branch May 23, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants