Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add _test.go suffix to the test file #1254

Merged
merged 1 commit into from
Apr 28, 2018
Merged

bugfix: add _test.go suffix to the test file #1254

merged 1 commit into from
Apr 28, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Apr 28, 2018

Should follow the golang convention.

Signed-off-by: Wei Fu [email protected]

Ⅰ. Describe what this PR did

Should follow the golang convention and add _test suffix to the case file.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

None

Ⅳ. Describe how to verify it

None

Ⅴ. Special notes for reviews

None

Should follow the golang convention.

Signed-off-by: Wei Fu <[email protected]>
@fuweid fuweid requested a review from Letty5411 April 28, 2018 06:05
@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/XS labels Apr 28, 2018
@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 28, 2018
@codecov-io
Copy link

Codecov Report

Merging #1254 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
+ Coverage   15.27%   15.36%   +0.08%     
==========================================
  Files         172      172              
  Lines       10691    10630      -61     
==========================================
  Hits         1633     1633              
+ Misses       8938     8877      -61     
  Partials      120      120
Impacted Files Coverage Δ
daemon/mgr/network.go 3.47% <0%> (-0.01%) ⬇️
cli/cli.go 0% <0%> (ø) ⬆️
daemon/mgr/container.go 0% <0%> (ø) ⬆️
cli/update.go 0% <0%> (ø) ⬆️
daemon/config/config.go 10% <0%> (+2.1%) ⬆️

@Letty5411 Letty5411 merged commit c3b5728 into AliyunContainerService:master Apr 28, 2018
@fuweid fuweid deleted the bugfix_use_test_suffix_for_test_file branch April 28, 2018 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants