bugfix: disable mux stdout and stderr if backend is not http #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YaoZengzeng <[email protected]>
fuweid
reviewed
Apr 28, 2018
| Stdout: true, | ||
| Stderr: true, | ||
| MemBuffer: &output, | ||
| MuxDisabled: true, | ||
| } | ||
|
|
||
| err = c.ContainerMgr.StartExec(ctx, execid, startConfig, attachConfig) |
There was a problem hiding this comment.
can we use pipeIO to check the status? I think that the spin check is not good for the performance.
BTW, if the cmd is top, the timeout can work with the io.Copy.
There was a problem hiding this comment.
Yes, it's ugly actually, I'll make it more elegant in the future.
Thanks for your advice.
There was a problem hiding this comment.
Could you add an issue to record this? @fuweid
Or @YaoZengzeng you to add this issue?
And thanks for the test fixing.
There was a problem hiding this comment.
@allencloud @YaoZengzeng I will add the issue for this. Thanks
Codecov Report
@@ Coverage Diff @@
## master #1250 +/- ##
==========================================
+ Coverage 15.27% 15.28% +0.01%
==========================================
Files 172 172
Lines 10691 10682 -9
==========================================
Hits 1633 1633
+ Misses 8938 8929 -9
Partials 120 120
|
|
LGTM |
pouchrobot
added
the
LGTM
This was referenced May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
Yesterday we skip some tests of CRI.
It's so dangerous, So I make a quick fix to make it all right :)
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews