bugfix: free resource after exec exit #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1240 +/- ##
==========================================
+ Coverage 15.21% 15.35% +0.14%
==========================================
Files 172 172
Lines 10735 10632 -103
==========================================
Hits 1633 1633
+ Misses 8981 8879 -102
+ Partials 121 120 -1
|
allencloud
reviewed
May 4, 2018
ctrd/container.go
Outdated
| @@ -89,6 +89,11 @@ func (c *Client) ExecContainer(ctx context.Context, process *Process) error { | |||
| break | |||
| } | |||
| } | |||
|
|
|||
| // delete the finish exec process in containerd | |||
|
I am wondering if we could add a integration to cover this case? @Ace-Tang |
|
I donnot think so, just like not close file or some other resource, WDYT, @allencloud |
when we start a exec process in containerd, we should do delete operate after exec process exit, to delete exec pid file. Signed-off-by: Ace-Tang <[email protected]>
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we start a exec process in containerd, we should do
delete operate after exec process exit, to delete exec pid file.
Signed-off-by: Ace-Tang [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
fix exec process pid leak, like:
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews